fix java.io.IOException: ... Argument list too long during pex generation.
#543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng` during pex generation. In certain circumstance, a large number of `--source` args are passed to the `_pex` script which causes an IOException to be thrown by bazel. This refactors the rule to write the args to a file and pass that single path as an arg to the `_pex` script. The script then opens that file and feeds it into the arg parser instead. fixes aspect-build#542
|
|
|
|
I could add a new |
thesayyn
reviewed
Apr 28, 2025
| @@ -113,10 +113,18 @@ def _py_python_pex_impl(ctx): | |||
| ) | |||
| args.add(output, format = "--output-file=%s") | |||
|
|
|||
| # The argument list can become quite long which can throw java.io.IOException Argument list too long. | |||
| # Instead write the args to a file and read that file at runtime | |||
| args_file = ctx.actions.declare_file("args.txt") | |||
There was a problem hiding this comment.
https://bazel.build/rules/lib/builtins/Args.html#use_param_file is what you want here.
There was a problem hiding this comment.
you can revert everything else on this by using args.use_param_file(use_always = True)
There was a problem hiding this comment.
Thanks, I hadn't seen that api before. I don't write rules often.
There was a problem hiding this comment.
Let me know when you make the changes, i'll review again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain circumstance, a large number of
--sourceargs are passed to the_pexscript which causes an IOException to be thrown by bazel. This refactors the rule to write the args to a file and pass that single path as an arg to the_pexscript. The script then opens that file and feeds it into the arg parser instead.fixes #542
Test plan
py/tests/py-pex-binary