Adding Azure Table storage and ComosDB table provider #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jinhuafei
commented
Aug 13, 2018
Jinhuafei
commented
- Add provider for Azure table storage and CosmosDB table
- Update outputcache async module
HongGit
reviewed
Aug 21, 2018
| if (reader.Read()) { | ||
| if ((DateTime)reader["UtcExpiry"] > DateTime.Now.ToUniversalTime()) { | ||
| return BinarySerializer.Deserialize((byte[])reader["Value"]); | ||
| } |
There was a problem hiding this comment.
Should this be sync or async operation? I see #region mentions "private sync method".
There was a problem hiding this comment.
this is sync code. Previous code causes deadlock under asp.net syncronizationcontext.
There was a problem hiding this comment.
Does this apply to all the comments below?
HongGit
reviewed
Aug 21, 2018
| using (var connection = new SqlConnection(ConnectionString)) { | ||
| SqlExecuteNonQuery(connection, cmd); | ||
| } | ||
| return entry; |
There was a problem hiding this comment.
This one too, change from Async to sync now, it this intended?
HongGit
reviewed
Aug 21, 2018
| } | ||
|
|
||
| private bool DoesKeyExist(string key) { | ||
| return DoesKeyExistAsync(key).GetAwaiter().GetResult(); | ||
| using (var cmd = CreateDoesKeyExistCommand(key)) { |
HongGit
reviewed
Aug 21, 2018
| } | ||
|
|
||
| private void RemoveEntry(string key) { | ||
| RemoveEntryAsync(key).GetAwaiter().GetResult(); | ||
| using (var cmd = CreateRemoveEntryCommand(key)) { |
HongGit
reviewed
Aug 21, 2018
| } | ||
|
|
||
| private void UpdateEntry(string key, object entry, DateTime utcExpiry) { | ||
| UpdateEntryAsync(key, entry, utcExpiry).GetAwaiter().GetResult(); | ||
| using (var cmd = CreateUpdateEntryCommand(key, entry, utcExpiry)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.