Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Move System.Data.SqlClient version from csproj to dependencies.props #303

Merged
merged 1 commit into from
May 3, 2017
Merged

Move System.Data.SqlClient version from csproj to dependencies.props #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions build/dependencies.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
<Project>
<PropertyGroup>
<AspNetCoreVersion>2.0.0-preview1-*</AspNetCoreVersion>

<!--
* Use 4.4.0-* instead of $(CoreFxVersion) to address "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
* https://github.com/dotnet/corefx/issues/18406
* Revert if and when $(CoreFxVersion) is upgraded to 4.4.0-*
-->
<SqlClientVersion>4.4.0-*</SqlClientVersion>

<CoreFxVersion>4.3.0</CoreFxVersion>
<InternalAspNetCoreSdkVersion>2.0.0-*</InternalAspNetCoreSdkVersion>
<MoqVersion>4.7.1</MoqVersion>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.Extensions.Caching.SqlServer/Microsoft.Extensions.Caching.SqlServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.2' ">
<!--
* Use 4.4.0-* instead of $(CoreFxVersion) to address "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
* Use $(SqlClientVersion) instead of $(CoreFxVersion) to address "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
* https://github.com/dotnet/corefx/issues/18406
* Revert if and when $(CoreFxVersion) is upgraded to 4.4.0-*
* Revert if and when $(CoreFxVersion) is upgraded to match $(SqlClientVersion)
-->
<PackageReference Include="System.Data.SqlClient" Version="4.4.0-*" />
<PackageReference Include="System.Data.SqlClient" Version="$(SqlClientVersion)" />
</ItemGroup>

</Project>