This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Upgrade StackExchange.Redis.StrongName to version 1.2.3 #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikeharder
commented
May 8, 2017
mikeharder
commented
- Addresses package downgrade warnings (Address package downgrade warnings #301)
- Addresses package downgrade warnings (#301)
kichalla
approved these changes
May 8, 2017
There was a problem hiding this comment.
FYI...This PR seems to be based on dev rather than preview1 branch.
You would need to make changes to this line too: https://github.com/aspnet/BuildTools/blob/dev/src/NuGetPackageVerifier/third-party.json#L65
|
@kichalla: Moved PR to preview1. I will create a PR for BuildTools as well. |
kichalla
reviewed
May 8, 2017
| @@ -16,6 +16,7 @@ branches: | |||
| - release | |||
| - dev | |||
| - /^(.*\/)?ci-.*$/ | |||
| - /^rel\/.*/ | |||
There was a problem hiding this comment.
👍 We should add a work item to track making these changes in all our repos as this would be the usual format for future releases too
Eilon
approved these changes
May 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.