Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Improve the comment for the prefix parameter in the AddEnvironmentVariables method #488

Closed
@miguelcrpinto

Description

@miguelcrpinto

The /// comment for the prefix parameter of the AddEnvironmentVariables method is a bit misleading as it doesn't only filter the environment variables but also removes the provided prefix from the variable name. This behavior should be mentioned in the comments.

This has already been changed/improved in the documentation side and I think it would also make sense to improve on the code comments side. Please check the pull request in the documentation repo: dotnet/AspNetCore.Docs#1777

I spent a few hours myself trying to figure out why my environment variables weren't being loaded and why weren't they overriding my variables in the appsettings.json. Lets help other developers with this small change in the comments.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions