Rename events on PhysicalFileWatcher can throw - Crashing VS.

[NTaylorMullen]

In some of Visual Studios test cases when they open a file => new web app 50+ times they eventually encounter crashes here. Essentially Directory.EnumerateFileSystemEntries explodes due to a node_modules file being renamed then locked.

This is a problem for Visual Studio because it ends up crashing it; however, it is infrequent. This can be mitigated by changing Mvc/Razor to only monitor the Views folder, it currently gets file watcher change events for all of the node_modules folder additions/renames during restore. This can also be fixed across the board by catching around this logic.

Not sure of the severity of this issue.

/cc @Eilon @ToddGrun @pranavkm

[Eilon]

@NTaylorMullen this shouldn't crash VS no matter what. Did you open a VS bug?

[ToddGrun]

VS doesn't own any of the code on this stack. The exception never gets caught and ends up crashing VS.

[Eilon]

@ToddGrun hmm then how does it crash VS?

[ToddGrun]

@Eilon -- An unhandled exception on a background thread will kill VS.

[Eilon]

Ah, background thread, got it!

[Eilon]

@muratg @DamianEdwards should we consider a hot-fix here for RC2 to at least try-catch? And do a better fix for RTM?

[muratg]

@Eilon yes, I think a simple fix in RC2 is worthy, considering how bad the experience is.

[Eilon]

@muratg can you send email for approval?

[NTaylorMullen]

98ea34e

[DamianEdwards]

@NTaylorMullen that commit is in to dev, is this going in to release as well?

[NTaylorMullen]

Oops pasted the dev commit instead of the release commit (it went into release first).