Output to console that the application is shutting down gracefully

[mrahhal]

Until recently whenever I wanted to stop my app I felt that ctrl+c felt really slow without a reason, I didn't know that it was canceling the shutdown to wait for the main thread to exit gracefully.

So perhaps output a message after this line of code to say that "Application is shutting down." so that it doesn't feel like nothing is going on?

[davidfowl]

How long did it take?

[mrahhal]

Takes a while sometimes, most of the times not so much. The problem is that people won't know what's going on and will just force it to exit (that's what I've been doing). This might or might not be problematic, I use IApplicationLifetime to clean stuff up for example so this got me to think.

[davidfowl]

This might or might not be problematic, I use IApplicationLifetime to clean stuff up for example so this got me to think.

That makes sense. It really won't help in the general case (since this only helps when looking at the console directly) but I don't see a problem doing this.

[mrahhal]

Yeah, that's my reasoning also. I'll do a PR.

[davidfowl]

We'll likely not take this for 1.0.0 since we're pretty much locking down. Also consider this bug that we do plan to fix #770 (which is about sprinkling Console messages that need to be turned off sometimes).

[mrahhal]

Oh makes sense, then feel free to close this if you want.

[mrahhal]

@davidfowl I did a PR anyway. Feel free to do whatever is appropriate.

[davidfowl]

Thanks!

[muratg]

@Tratcher Could you take a look? Seems simple enough to take in 1.0.0 for me.

[Tratcher]

It looks fine, but it can wait, it's only a cosmetic issue.