This repository was archived by the owner on Nov 29, 2018. It is now read-only.
Damianedwards/app prefix #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianEdwards
force-pushed
the
damianedwards/app-prefix
branch
from
2838b95 to
f769ce6
Compare
| @@ -69,7 +68,8 @@ public IStringLocalizer Create(Type resourceSource) | |||
|
|
|||
| var baseName = string.IsNullOrEmpty(_resourcesRelativePath) | |||
| ? typeInfo.FullName | |||
| : _applicationEnvironment.ApplicationName + "." + _resourcesRelativePath + typeInfo.FullName; | |||
| : _applicationEnvironment.ApplicationName + "." + _resourcesRelativePath | |||
| + TrimPrefix(typeInfo.FullName, _applicationEnvironment.ApplicationName + "."); | |||
|
Seems fine. |
DamianEdwards
force-pushed
the
damianedwards/app-prefix
branch
from
f769ce6 to
e72d3cb
Compare
…se name: - Only applies when LocalizationOptions.ResourcesPath is set - #167
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceManagerStringLocalizerFactorynow trims the application name from the start of the type name/location whenLocalizationOptions.ResourcesPathis set, so thatIStringLocalizer<MyController>will look for resource nameMyApplication.Resources.Controllers.MyControllerinstead ofMyApplication.Resources.MyApplication.Controllers.MyController#167
@rynowak @ryanbrandenburg