DisplayName in new AuthN Plumbing?

[leastprivilege]

How do I set it? It's gone from the options class.

[Tratcher]

Security/src/Microsoft.AspNetCore.Authentication/AuthenticationBuilder.cs

Line 37 in ff9f145

public virtual AuthenticationBuilder AddScheme<TOptions, THandler>(string authenticationScheme, string displayName, Action<TOptions> configureOptions)

Security/src/Microsoft.AspNetCore.Authentication/AuthenticationServiceCollectionExtensions.cs

Line 50 in df325de

public static IServiceCollection AddScheme<TOptions, THandler>(this IServiceCollection services, string authenticationScheme, string displayName, Action<AuthenticationSchemeBuilder> configureScheme, Action<TOptions> configureOptions)

@HaoK is this exposed anywhere else? E.g. I don't see a way to change it for Google, OIDC, etc..

[leastprivilege]

but not here

https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectExtensions.cs#L20

[Tratcher]

It's set here to match the scheme name: https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectExtensions.cs#L23
Needs an overload to set the display name.

[HaoK]

Yeah we don't have those overloads in the security layer right now, so you'd have to drop down and use the lower overload to tweak the display name

[kevinchalet]

If you decide to fix that in 2.0 (and I personally hope you will), please also fix aspnet/IISIntegration#391 (I'm fine submitting a PR if you prefer).

[HaoK]

Doubt we are doing that now, since its a non breaking change in 2.1

You can probably workaround this via directly tweaking the DisplayName via AuthenticationOptions.SchemeMap:

services.Configure<AuthenticationOptions>(o => o.SchemeMap["OIDC"].DisplayName = whatever

[leastprivilege]

That's ridiculous.

[kevinchalet]

Doubt we are doing that now, since its a non breaking change in 2.1

Well, it automatically means waiting maybe 5 or 6 months more before moving to 2.x.
And while you can indeed work around this limitation with the "classical" handlers, it's not possible with the host handlers.

[HaoK]

What are you trying to do with display name that is so critical? Check if its null?

[kevinchalet]

@HaoK aspnet/IISIntegration#391 (comment)

[HaoK]

So you can just write your own filtering for which handlers to display for the external schemes, you don't have to use DisplayName != null as your condition. Why don't you just merge the list you have with the Windows scheme?

[HaoK]

You are able to inspect the schemes yourself via IAuthenticationSchemeProvider, just compute the display list using that directly...

[HaoK]

Its up to the app to decide which schemes are appropriate anyways, we wrote some sugar (that I think lives in Identity?) that filters the schemes using DisplayName != null, but its just sugar

[kevinchalet]

Sure, why not reinventing the wheel and using a hardcoded display name in your views when you could simply rely on SignInManager.GetExternalAuthenticationSchemesAsync(), that does the right thing for you and is used in the default templates...

[HaoK]

Well, you can just wait til 2.1 as you said if you prefer that instead of using the workaround