Add timeout for chrome full page screenshot

[SergeyPirogov]

I see that it scrolls the page and then back to top and take a screenshot. There should be a possibility to set a timeout between these operations because sometimes need to wait while page will be fully rendered and all effects stop after scroll

[glibas]

Hi @SergeyPirogov ,

Thank you for your suggestion. There is a timeout after scroll here

selenium-shutterbug/src/main/java/com/assertthat/selenium_shutterbug/utils/web/Browser.java

Line 186 in c20770b

wait(scrollTimeout);

Can be used like so Shutterbug.shootPage(driver, ScrollStrategy.WHOLE_PAGE , scrollTimeout)

If that wont work we can then add a separate wait after all scrolling finishes.

[SergeyPirogov]

The problem is that sometimes there should be timeout between SetDeviceMetrics and captureScreenshot actions

[glibas]

Alright, np, I'll add it in

[glibas]

Snapshot with this change is available here https://oss.sonatype.org/content/repositories/snapshots/com/assertthat/selenium-shutterbug/0.9.4-SNAPSHOT/

[SergeyPirogov]

There even might be a better solution for these timeouts. Just to replace both of them with Java Callable. So users will be able to wait for some events using external tools (ex Selenium, Selenide)

[glibas]

Thank you for suggestion. Added conditional waiting after scroll and before taking screenshot d4ddbe8

So it can be used like

        Shutterbug.wait(visibilityOfElementLocated(By.id("someId")), 5)
                .shootPage(driver, ScrollStrategy.WHOLE_PAGE).save();

The change will be available in next minor version update