Skip to content

Make sure 'run' always passes the latest props/options #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Aug 5, 2019

Description

Fixed useAsync passing stale props to deferFn (#69).

Breaking changes

None.

Checklist

Make sure you check all the boxes. You can omit items that are not applicable.

  • Added / updated the unit tests

@vercel
Copy link

vercel bot commented Aug 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #71 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   98.83%   98.87%   +0.03%     
==========================================
  Files          10       10              
  Lines         689      709      +20     
  Branches      161      162       +1     
==========================================
+ Hits          681      701      +20     
  Misses          6        6              
  Partials        2        2
Impacted Files Coverage Δ
packages/react-async/src/useAsync.js 98.88% <100%> (ø) ⬆️
packages/react-async/src/specs.js 99.71% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22acd0...e9b2063. Read the comment docs.

@ghengeveld ghengeveld merged commit 0da6eb8 into master Aug 5, 2019
@ghengeveld ghengeveld deleted the 69-stale-run-props branch August 5, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant