fix: execute notification center completion handlers on the main thread #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ortto team 👋
While testing push notifications on iOS, I noticed that the app crashes after tapping on a notification. XCode provided a hint pointing to the
MessagingPush+AppDelegate.swift
file.It turns out that the
completionHandler
is being called off the main thread, which seems to cause issues — probably due to a UI-related action like navigating to a specific tab.I tried wrapping the
completionHandler
inDispatchQueue.main.async
, and that resolved the crash. To be safe, I applied the same change everywherecompletionHandler
is used.The fix has been tested and appears to work well on my side.
Happy to help further if needed — let me know if you have a different approach in mind!