feat: adjust etna builder props #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rictorlome
reviewed
Oct 14, 2024
There was a problem hiding this comment.
I am good with this for now. I think, per our conversation with @bferenc , we might want to actually make use of the threshold and locktime, but that can be a follow up.
Also left a question regarding duplication of changeOutput parameters.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
# [4.1.0](v4.0.5...v4.1.0) (2024-11-22) ### Bug Fixes * add .getSigIndices() for DisableL1ValidatorTx ([ac7e0d7](ac7e0d7)) * add missing L1Validator props ([b31f376](b31f376)) * address review feedback and fix adding stakeouts ([94e1361](94e1361)) * burn amount validation for new tx types ([d54bb02](d54bb02)) * change minDelegatorStake to uint64 ([#903](#903)) ([1ecf74e](1ecf74e)) * complexity calculations and associated tests ([0e90227](0e90227)) * convertsubnettx types ([811304b](811304b)) * export PChainOwner and ConvertSubnetValidator ([ba50da3](ba50da3)) * expose calculateFee ([#910](#910)) ([7900273](7900273)) * network id type error ([0ad71b1](0ad71b1)) * only allow AVAX assets on importtx ([141294d](141294d)) * remove etna builder minPrice usage and update examples ([#881](#881)) ([5b7868a](5b7868a)) * typo in upgrades type ([db80e73](db80e73)) * usable unlocked utxos ([6f2979f](6f2979f)) ### Features * add .getL1Validator() to P-Chain api ([cc4574c](cc4574c)) * add `DisableSubnetValidatorTx` and `SetSubnetValidatorWeightTx` ([#890](#890)) ([d80b456](d80b456)) * add convertSubnetValidator tests and fix for passing ([c69e1e6](c69e1e6)) * add etna builder spend logic ([12dcdef](12dcdef)) * add fee calculator ([2651bf5](2651bf5)) * add getsubnet api endpoint ([#920](#920)) ([0b4eb57](0b4eb57)) * add info.getEtnaTime and pvm.getFeeConfig api ([86bf791](86bf791)) * add new etna experimental spend ([8007fa1](8007fa1)) * add new etnaBuilder for p-chain ([d485942](d485942)) * add nodePOP to GetNodeIdResponse" ([#893](#893)) ([11bcd3b](11bcd3b)) * add p-chain auth complexity ([b64d15a](b64d15a)) * add p-chain etna examples ([36dd950](36dd950)) * add platform.getFeeState and update etna builder ([#879](#879)) ([47f216e](47f216e)) * add pvm builder complexity logic ([03bb77a](03bb77a)) * add RegisterSubnetValidatorTx ([#891](#891)) ([2746ee8](2746ee8)) * add txComplexity ([eb04ec9](eb04ec9)) * add validateAvaxBurnedAmountEtna ([b685484](b685484)) * adjust etna builder props ([#882](#882)) ([ad65b27](ad65b27)) * adjust validateBurnedAmount params ([e071a75](e071a75)) * base pvm complexity fns ([bba2054](bba2054)) * breakout spend reducers filters ([61946ff](61946ff)) * convertSubtnetTx ([6bba3b3](6bba3b3)) * etna builder wrap up bug fixes and tests ([5e6ce59](5e6ce59)) * etna-builder fixes and more tests ([62cabd2](62cabd2)) * expose new etna builder via experimental exports ([d4c5c0d](d4c5c0d)) * implement IncreaseBalanceTx ([683b56f](683b56f)), closes [#888](#888) [#873](#873) * opt-in consolidate outputs ([7183cfe](7183cfe)) * pass gasPrice and weights as part of feeConfig into txBuilder ([dd6c8fe](dd6c8fe)) * refactor for ACP-77 nomenclature ([a18fbff](a18fbff)) * spend reducers and tests ([0fe9515](0fe9515)) * spend reducers and tests ([4a29afc](4a29afc)) * update acp-103 complexities ([#919](#919)) ([7fca80c](7fca80c)) * update getUpgradesInfo function name ([ee3029a](ee3029a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/vms/pvm/etna-builder/builder.tsfile and its related test files. The primary focus is on refactoring the code to replace the usage ofSpendOptionswith individual parameters and improving code readability. Additionally, a minor typo was corrected insrc/vms/common/models.ts.Changes
spendOptionsprop.changeAddressesBytescommon builder prop. Defaults to use thefromAddressesBytes.memocommon builder prop. Defaults to empty Uint8Array.minIssuanceTimecommon builder prop. Defaults to current unix time in seconds.newImportTxtoAddressesprop totoAddressesBytes.Migration
spendOptions.changeAddresses->changeAddressesBytes.spendOptions.memo->memo.spendOptions.minIssuanceTime->minIssuanceTime.toAddresses->toAddressesBytes.Any usage of
spendOptions.locktimeorspendOptions.thresholdneed removed. Those props didn't do anything in the builder, and therefore caused confusion.