prevent unused variable error #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [previous commit][0] that changed the ACK pkg/resource templates introduced an error for controllers that have CREATE or UPDATE implementations where the Output shape from the operation sets no fields on the CR. In these cases, attempting to build these controllers was resulting in a build failure, like this for the RDS controller: ``` pkg/resource/db_parameter_group/sdk.go:205:6: resp declared but not used ``` This corrects that by using a blanking technique immediately after the variable declaration: ``` var resp *SomeSDKShape; _ = resp; ``` [0]: a42b4a1
jaypipes
added a commit
to jaypipes/ack-rds-controller
that referenced
this pull request
Jun 23, 2021
Regenerates the RDS controller to get to ACK runtime v0.2.3 and the new logging changes. Includes the changes from aws-controllers-k8s/code-generator#101
ack-bot
pushed a commit
to aws-controllers-k8s/rds-controller
that referenced
this pull request
Jun 23, 2021
Regenerates the RDS controller to get to ACK runtime v0.2.3 and the new logging changes. Includes the changes from aws-controllers-k8s/code-generator#101 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RedbackThomson
pushed a commit
to RedbackThomson/ack-code-generator
that referenced
this pull request
Jun 24, 2021
A [previous commit][0] that changed the ACK pkg/resource templates introduced an error for controllers that have CREATE or UPDATE implementations where the Output shape from the operation sets no fields on the CR. In these cases, attempting to build these controllers was resulting in a build failure, like this for the RDS controller: ``` pkg/resource/db_parameter_group/sdk.go:205:6: resp declared but not used ``` This corrects that by using a blanking technique immediately after the variable declaration: ``` var resp *SomeSDKShape; _ = resp; ``` [0]: a42b4a1 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit that changed the ACK pkg/resource templates
introduced an error for controllers that have CREATE or UPDATE
implementations where the Output shape from the operation sets no fields
on the CR.
In these cases, attempting to build these controllers was resulting in a
build failure, like this for the RDS controller:
This corrects that by using a blanking technique immediately after the
variable declaration:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.