handle renamed fields for resource identifiers #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that outputs Go code that sets `Spec` or `Status` fields to a resource identifier field was not accounting for cases where we renamed the field. Such is the case for many of the RDS controller's resources, since all the identifier fields for all resources are "de-stuttured" by renaming, for example, `DBSubnetGroupName` to just `Name` or `DBClusterParameterGroupName` to just `Name`. This patch simply ensures we account for renamed fields in the Spec and Status during calls to `pkg/generate/code.SetResourceIdentifiers` and adds a unit test to ensure we don't regress in the future. Issue aws-controllers-k8s/community#852
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
pushed a commit
to a-hilaly/ack-code-generator
that referenced
this pull request
Jul 6, 2021
The code that outputs Go code that sets `Spec` or `Status` fields to a resource identifier field was not accounting for cases where we renamed the field. Such is the case for many of the RDS controller's resources, since all the identifier fields for all resources are "de-stuttured" by renaming, for example, `DBSubnetGroupName` to just `Name` or `DBClusterParameterGroupName` to just `Name`. This patch simply ensures we account for renamed fields in the Spec and Status during calls to `pkg/generate/code.SetResourceIdentifiers` and adds a unit test to ensure we don't regress in the future. Issue aws-controllers-k8s/community#852 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson
pushed a commit
to RedbackThomson/ack-code-generator
that referenced
this pull request
Jul 8, 2021
The code that outputs Go code that sets `Spec` or `Status` fields to a resource identifier field was not accounting for cases where we renamed the field. Such is the case for many of the RDS controller's resources, since all the identifier fields for all resources are "de-stuttured" by renaming, for example, `DBSubnetGroupName` to just `Name` or `DBClusterParameterGroupName` to just `Name`. This patch simply ensures we account for renamed fields in the Spec and Status during calls to `pkg/generate/code.SetResourceIdentifiers` and adds a unit test to ensure we don't regress in the future. Issue aws-controllers-k8s/community#852 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that outputs Go code that sets
SpecorStatusfields to aresource identifier field was not accounting for cases where we renamed
the field. Such is the case for many of the RDS controller's resources,
since all the identifier fields for all resources are "de-stuttured" by
renaming, for example,
DBSubnetGroupNameto justNameorDBClusterParameterGroupNameto justName.This patch simply ensures we account for renamed fields in the Spec and
Status during calls to
pkg/generate/code.SetResourceIdentifiersandadds a unit test to ensure we don't regress in the future.
Issue aws-controllers-k8s/community#852
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.