Recursively build a clean GoType for nested maps and arrays #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug where `ack-generate` used to prepend a `[]` prefix to any map of structs (example `Route_SDK.RequestParameters` in apigatewayv2) Also moves the GoType cleanup logic to a separate function `model.getShapeCleanGoType` to simplify `model.GetTypeDefs` code.
jaypipes
approved these changes
Jul 15, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue N/A
Description of changes:
This patch fixes a bug where
ack-generateused to prepend a[]prefix to any map of structs (example
Route_SDK.RequestParametersin apigatewayv2)
Also in the same PR, moving the GoType cleanup logic to a separate
function
model.getShapeCleanGoTypeto simplifymodel.GetTypeDefscode.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.