-
Notifications
You must be signed in to change notification settings - Fork 209
use readOnlyRootFilesystem #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use readOnlyRootFilesystem #548
Conversation
Hi @bradwhitfield. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@bradwhitfield: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test ec2-controller-test |
Is the verify-attribution something I can fix? I'm not sure what the check is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bradwhitfield !!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, bradwhitfield The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bradwhitfield the verify-attribution is a new prow job that is not mandatory for now :) |
Issue #, if available:
aws-controllers-k8s/community#2166
Description of changes:
Configure the generated helm chart to set a readOnlyRootFilesystem on pods for ACK controllers to improve the security posture.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.