Skip to content

Make controller base_image version an argument #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

Make controller base_image version an argument #551

merged 1 commit into from
Oct 15, 2024

Conversation

michaelhtm
Copy link
Member

Description of changes:
This change allows us to pass the base image version
as an argument allowing us to pass the latest one after each release

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler October 4, 2024 01:24
a-hilaly
a-hilaly reviewed Oct 4, 2024
View reviewed changes
a-hilaly
a-hilaly reviewed Oct 4, 2024
View reviewed changes
@michaelhtm
Make controller base_image version an argument
3846977 
This change allows us to pass the base image version as an argument
allowing us to pass the latest one after each release
a-hilaly
a-hilaly approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Oct 14, 2024
@a-hilaly
Copy link
Member

/retest

2 similar comments
@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 15, 2024 •
edited
Loading

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 3846977 link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit ab15f92 into aws-controllers-k8s:main Oct 15, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhtm @a-hilaly