Skip to content

Replace To/FromACKTags with to/fromACKTagsWithKeyOrder #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

Replace To/FromACKTags with to/fromACKTagsWithKeyOrder #573

merged 1 commit into from
Mar 14, 2025

Conversation

michaelhtm
Copy link
Member

Description of changes:
This change also ensures these functions are generated using
go code instead of templating. This keeps the code cleaner and testable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler March 13, 2025 03:44
@michaelhtm michaelhtm force-pushed the change-to/fromACKsign branch 2 times, most recently from 8bfa471 to e173c48 Compare March 13, 2025 21:28
@michaelhtm
Copy link
Member Author

/retest

a-hilaly
a-hilaly reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t! Thanks michael!

@michaelhtm michaelhtm force-pushed the change-to/fromACKsign branch from e173c48 to acc66b0 Compare March 14, 2025 01:58
a-hilaly
a-hilaly reviewed Mar 14, 2025
View reviewed changes
a-hilaly
a-hilaly reviewed Mar 14, 2025
View reviewed changes
a-hilaly
a-hilaly approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ack-prow ack-prow bot added the approved label Mar 14, 2025
@michaelhtm
Replace To/FromACKTags with convertToOrderedACKTags and fromACKTags
becb821 
Besides changing just the funciton names, it also changes their
signature introduced in previous PR, to maintain tag order
during conversion.
This change also ensures these funcitons are generated using go
code instead of templating. This keeps the code cleaner
and testable.
@michaelhtm michaelhtm force-pushed the change-to/fromACKsign branch from acc66b0 to becb821 Compare March 14, 2025 02:14
@michaelhtm
Copy link
Member Author

/retest

2 similar comments
@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

/retest

a-hilaly
a-hilaly approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-hilaly
Copy link
Member

/retest

rushmash91
rushmash91 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@rushmash91 rushmash91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay less templates!! Thank you @michaelhtm 🚀

@a-hilaly
Copy link
Member

/retest
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Member Author

/retest

1 similar comment
@michaelhtm
Copy link
Member Author

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Mar 14, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-controller-test becb821 link true /test eks-controller-test
verify-attribution becb821 link false /test verify-attribution
s3-olm-test becb821 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly a-hilaly merged commit 0ab258c into aws-controllers-k8s:main Mar 14, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@rushmash91 rushmash91 rushmash91 approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelhtm @a-hilaly @rushmash91