Skip to content

feat: Make helm chart names dynamic #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Make helm chart names dynamic #593

wants to merge 2 commits into from

Conversation

michaelhtm
Copy link
Member

Issue #2430

Description of changes:
extra changes:
add labels to roles/rolebindings

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 May 14, 2025 20:37
@ack-prow ACK Prow
Copy link

ack-prow bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label May 14, 2025
@michaelhtm michaelhtm force-pushed the feat/renameclusterroles branch 2 times, most recently from 810b97a to 1a3ee22 Compare May 14, 2025 21:13
a-hilaly
a-hilaly reviewed May 14, 2025
View reviewed changes
templates/helm/templates/caches-role-binding.yaml.tpl Outdated
name: ack-namespaces-cache-{{ .ControllerName }}-controller
name: {{ IncludeTemplate "app.fullname" }}-namespaces-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelhtm ! is app.fullname unique per installation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe so..it mostly depends on what you name the app when installing it.

@alexzandershevchenko
Copy link

Hey @michaelhtm , any ETA on this release?

@michaelhtm
Copy link
Member Author

Hello @alexzandershevchenko
We should have this feature released latest by EOW

@michaelhtm
feat: Make helm chart names dynamic
85a11f7 
extra changes:
add labels to roles/rolebindings
@michaelhtm michaelhtm force-pushed the feat/renameclusterroles branch from 1a3ee22 to 85a11f7 Compare May 27, 2025 18:19
@michaelhtm michaelhtm mentioned this pull request May 27, 2025
Open
@alexzandershevchenko
Copy link

Sounds great, thanks, @michaelhtm .

Can we add labels to all created resources as well?

  labels:
    app.kubernetes.io/name: {{ IncludeTemplate "app.name" }}
    app.kubernetes.io/instance: {{ "{{ .Release.Name }}" }}
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: {{ "{{ .Chart.AppVersion | quote }}" }}
    k8s-app: {{ IncludeTemplate "app.name" }}
    helm.sh/chart: {{ IncludeTemplate "chart.name-version" }}

@michaelhtm
Copy link
Member Author

@alexzandershevchenko of course

@michaelhtm
Copy link
Member Author

/test lambda-controller-test

@michaelhtm michaelhtm force-pushed the feat/renameclusterroles branch from 68a50bd to c8e6b7d Compare May 30, 2025 19:33
@ack-prow ACK Prow
Copy link

ack-prow bot commented May 30, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution c8e6b7d link false /test verify-attribution
s3-olm-test c8e6b7d link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member Author

/test ec2-controller-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly left review comments

@jlbutler jlbutler Awaiting requested review from jlbutler

@rushmash91 rushmash91 Awaiting requested review from rushmash91

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelhtm @alexzandershevchenko @a-hilaly