temp: sample dynamic names for helm clusterrolebinding #79
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
force-pushed
the
temp/testgenertingdynamichelmcharts
branch
from
ea09a97 to
47d3908
Compare
| @@ -1,7 +1,7 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRole | |||
| metadata: | |||
| name: ack-namespaces-cache-sqs-controller | |||
| name: {{ include "ack-sqs-controller.app.fullname" . }}-namespaces-cache | |||
There was a problem hiding this comment.
Q: Would this change apply to every controller? And if yes, should this be applied done through the code-generator?
There was a problem hiding this comment.
This is a code-gen feature..just wanted to show the generated output..
Here's the code-gen PR: aws-controllers-k8s/code-generator#593
michaelhtm
force-pushed
the
temp/testgenertingdynamichelmcharts
branch
10 times, most recently
from
3b8afef to
0733651
Compare
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
|
/wip |
michaelhtm
force-pushed
the
temp/testgenertingdynamichelmcharts
branch
4 times, most recently
from
b5535fe to
72d588c
Compare
michaelhtm
force-pushed
the
temp/testgenertingdynamichelmcharts
branch
from
72d588c to
29e4fab
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.