Add Regex Pattern to documentation #596
Conversation
- Read smithy.api#pattern from aws-sdk-go-v2 JSON models - Add Regex pattern to documentation string if exists - Add test to verify pattern string is added when present
knottnt
force-pushed
the
document-regex-pattern
branch
from
26f687f to
1b9720d
Compare
|
/retest |
|
@knottnt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| // this is being added for type union specifically. We want to generate | ||
| // api as struct and handle setSDK and setResource differently | ||
| RealType string | ||
| RealType string |
|
Example of yaml produced by this change. agentName:
description: |-
A name for the agent that you create.
Regex Pattern: `^([0-9a-zA-Z][_-]?){1,100}$`
type: string |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow
bot
merged commit cfe9477
into
aws-controllers-k8s:main
Issue #, if available: 930
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.