Skip to content

panic if matchFieldName config contains an element that is not part of Spec or Status fields #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021

Conversation

a-hilaly
Copy link
Member

Part of aws-controllers-k8s/community#773

Description of changes:

  • panic if list_operation.matchFields configuration contains an element that is not part of Spec or Status fields

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from jaypipes and vijtrip2 May 17, 2021 12:07
@a-hilaly a-hilaly force-pushed the issue/773/sdkfind-2 branch from d351f7d to 845188d Compare May 17, 2021 12:08
@a-hilaly a-hilaly force-pushed the issue/773/sdkfind-2 branch from 845188d to cc05fbf Compare May 17, 2021 12:10
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tres bien, merci!

@ack-bot
Copy link
Collaborator

ack-bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes jaypipes merged commit 5d545b3 into aws-controllers-k8s:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants