Add a new generator config to append an Age printcolumn
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
resource-print-age
branch
from
72e19ef to
66d727c
Compare
Since All kubernetes resources have a `.metadata.creationTimestamp` field, we need a way to instruct the code generator to generate kubebuilder marker comments that will append the AGE field the `kubectl get` response. This patch extends `Resource.PrintConfig` to allow configuring the `ack-generate` to generate such marker comments.
a-hilaly
force-pushed
the
resource-print-age
branch
from
66d727c to
538402c
Compare
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
RedbackThomson
approved these changes
Jun 14, 2021
| @@ -50,6 +50,9 @@ type {{ .CRD.Kind }}Status struct { | |||
| {{- range $column := .CRD.AdditionalPrinterColumns }} | |||
| // +kubebuilder:printcolumn:name="{{$column.Name}}",type={{$column.Type}},JSONPath=`{{$column.JSONPath}}` | |||
| {{- end }} | |||
| {{- if .CRD.PrintAgeColumn }} | |||
| // +kubebuilder:printcolumn:name="Age",type="date",priority=0,JSONPath=".metadata.creationTimestamp" | |||
There was a problem hiding this comment.
That's also the default for all the builtin types (pods, services..)
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: aws-controllers-k8s/community#822
Since All kubernetes resources have a
.metadata.creationTimestampfield,we need a way to instruct the code generator to generate kubebuilder
marker comments that will append the AGE field the
kubectl getresponse.
This patch extends
Resource.PrintConfigto allow configuring theack-generateto generate such marker comments.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.