Skip to content

Update to ACK runtime v0.29.2, code-generator v0.29.2 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Jan 29, 2024

Update to ACK runtime v0.29.2, code-generator v0.29.2



NOTE:
This PR increments the release version of service controller from v1.2.5 to v1.2.6

Once this PR is merged, release v1.2.6 will be automatically created for sagemaker-controller

Please close this PR, if you do not want the new patch release for sagemaker-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sagemaker-controller ====
Copying common custom resource definitions into sagemaker
Building Kubernetes API objects for sagemaker
Generating deepcopy code for sagemaker
Generating custom resource definitions for sagemaker
Building service controller for sagemaker
Generating RBAC manifests for sagemaker
Running gofmt against generated code for sagemaker
Updating additional GitHub repository maintenance files
==== building sagemaker-controller release artifacts ====
Building release artifacts for sagemaker-v1.2.6
Generating common custom resource definitions
Generating custom resource definitions for sagemaker
Generating RBAC manifests for sagemaker

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested a review from surajkota as a code owner January 29, 2024 07:10
@ack-bot ack-bot requested a review from ryansteakley as a code owner January 29, 2024 07:10
@ack-prow ack-prow bot requested a review from rd-pong January 29, 2024 07:10
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link

ack-prow bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jan 29, 2024
@ack-prow ack-prow bot merged commit 64f81a3 into main Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants