Skip to content

Update to ACK runtime v0.46.1, code-generator v0.46.2 #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ aliases:
- a-hilaly
- jlbutler
- michaelhtm
- TiberiuGC
- rushmash91
- knottnt
# emeritus-core-ack-team:
# - TiberiuGC
# - jaypipes
# - jljaco
# - mhausenblas
Expand Down
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2025-05-02T16:35:12Z"
build_hash: f8dc5330705b3752ce07dce0ac831161fd4cb14f
build_date: "2025-05-13T05:00:16Z"
build_hash: 55bf57b2806c33a7fcd074be403f26ce3f8e58db
go_version: go1.24.2
version: v0.45.0
version: v0.46.2
api_directory_checksum: a0804e163a24b96c9fa36be8d0277bebfe1d5c77
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
Expand Down
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/sagemaker-controller
newTag: 1.2.17
newTag: 1.2.18
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.24.0
toolchain go1.24.1

require (
github.com/aws-controllers-k8s/runtime v0.45.0
github.com/aws-controllers-k8s/runtime v0.46.1
github.com/aws/aws-sdk-go v1.55.6
github.com/aws/aws-sdk-go-v2 v1.34.0
github.com/aws/aws-sdk-go-v2/service/sagemaker v1.173.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/aws-controllers-k8s/runtime v0.45.0 h1:b0xCqIE1SNve/jcJPW/QkCGkDmjxWtWTDFHKZpHJcFQ=
github.com/aws-controllers-k8s/runtime v0.45.0/go.mod h1:G2UMBKA7qgXG4JV16NTIUp715uqvUEvWaa7TG1I527U=
github.com/aws-controllers-k8s/runtime v0.46.1 h1:61RU6uYiFSp0cDhv52vAmaPzrebzoudtsp1fGkk6iLk=
github.com/aws-controllers-k8s/runtime v0.46.1/go.mod h1:G2UMBKA7qgXG4JV16NTIUp715uqvUEvWaa7TG1I527U=
github.com/aws/aws-sdk-go v1.55.6 h1:cSg4pvZ3m8dgYcgqB97MrcdjUmZ1BeMYKUxMMB89IPk=
github.com/aws/aws-sdk-go v1.55.6/go.mod h1:eRwEWoyTWFMVYVQzKMNHWP5/RV4xIUGMQfXQHfHkpNU=
github.com/aws/aws-sdk-go-v2 v1.34.0 h1:9iyL+cjifckRGEVpRKZP3eIxVlL06Qk1Tk13vreaVQU=
Expand Down
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: sagemaker-chart
description: A Helm chart for the ACK service controller for Amazon SageMaker (SageMaker)
version: 1.2.17
appVersion: 1.2.17
version: 1.2.18
appVersion: 1.2.18
home: https://github.com/aws-controllers-k8s/sagemaker-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/sagemaker-controller:1.2.17".
This chart deploys "public.ecr.aws/aws-controllers-k8s/sagemaker-controller:1.2.18".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
Expand Down
4 changes: 4 additions & 0 deletions helm/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ spec:
- "$(ACK_WATCH_NAMESPACE)"
- --watch-selectors
- "$(ACK_WATCH_SELECTORS)"
- --reconcile-resources
- "$(RECONCILE_RESOURCES)"
- --deletion-policy
- "$(DELETION_POLICY)"
{{- if .Values.leaderElection.enabled }}
Expand Down Expand Up @@ -107,6 +109,8 @@ spec:
value: {{ include "ack-sagemaker-controller.watch-namespace" . }}
- name: ACK_WATCH_SELECTORS
value: {{ .Values.watchSelectors }}
- name: RECONCILE_RESOURCES
value: {{ join "," .Values.reconcile.resources | quote }}
- name: DELETION_POLICY
value: {{ .Values.deletionPolicy }}
- name: LEADER_ELECTION_NAMESPACE
Expand Down
8 changes: 8 additions & 0 deletions helm/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,14 @@
},
"resourceMaxConcurrentSyncs": {
"type": "object"
},
"resources": {
"type": "array",
"items": {
"type": "string"
},
"description": "List of resource kinds to reconcile. If empty, all resources will be reconciled.",
"default": []
}
},
"type": "object"
Expand Down
30 changes: 29 additions & 1 deletion helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/sagemaker-controller
tag: 1.2.17
tag: 1.2.18
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down Expand Up @@ -137,6 +137,34 @@ reconcile:
# An object representing the reconcile max concurrent syncs configuration for each specific
# resource.
resourceMaxConcurrentSyncs: {}

# Set the value of resources to specify which resource kinds to reconcile.
# If empty, all resources will be reconciled.
# If specified, only the listed resource kinds will be reconciled.
resources:
- App
- DataQualityJobDefinition
- Domain
- Endpoint
- EndpointConfig
- FeatureGroup
- HyperParameterTuningJob
- InferenceComponent
- Model
- ModelBiasJobDefinition
- ModelExplainabilityJobDefinition
- ModelPackage
- ModelPackageGroup
- ModelQualityJobDefinition
- MonitoringSchedule
- NotebookInstance
- NotebookInstanceLifecycleConfig
- Pipeline
- PipelineExecution
- ProcessingJob
- TrainingJob
- TransformJob
- UserProfile

serviceAccount:
# Specifies whether a service account should be created
Expand Down