[WIP] driver metadata #1432
Open
[WIP] driver metadata #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
force-pushed
the
driver-metrics
branch
from
c7a91f2 to
30b47ec
Compare
sergiyvamz
force-pushed
the
driver-metrics
branch
4 times, most recently
from
8cf2546 to
c28c354
Compare
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
sergiyvamz
commented
Jun 5, 2025
| final @NonNull HostSpec hostSpec) { | ||
|
|
||
| final String connectionAttributes = String.format( | ||
| "_jdbc_wrapper_name:aws_jdbc_driver,_jdbc_wrapper_version:%s,_jdbc_wrapper_plugins:%s", |
There was a problem hiding this comment.
Reporting metrics for MySQL
sergiyvamz
commented
Jun 5, 2025
| // We'd like to make this query as "unique" as possible so we add such wierd WHERE conditions. | ||
| // That helps to keep this query in pg_stat_statements. | ||
| return String.format( | ||
| "SELECT /* _driver:aws_jdbc_driver,_driver_version:%s,_jdbc_wrapper_plugins:%s */ 'version', VERSION()" |
There was a problem hiding this comment.
Reporting metrics with query comment for PG.
sergiyvamz
force-pushed
the
driver-metrics
branch
from
c367338 to
4b34e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide driver metadata as query comment, or a connection attributes
Additional Reviewers
@karenc-bq
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.