Skip to content

Potential fix for code scanning alert no. 1: Workflow does not contain permissions #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025

Conversation

rlymbur
Copy link
Contributor

@rlymbur rlymbur commented May 23, 2025

Potential fix for https://github.com/aws/aws-application-networking-k8s/security/code-scanning/1

To fix the issue, we will add a permissions block at the workflow level to explicitly define the required permissions. Based on the workflow's operations, it likely needs contents: write to deploy documentation using mike. However, we will start with the minimal permissions (contents: read) and adjust to contents: write if necessary for the workflow to function correctly.

The permissions block will be added at the root level of the workflow, applying to all jobs. This ensures that the GITHUB_TOKEN used in the workflow has only the necessary permissions.


Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@rlymbur rlymbur marked this pull request as ready for review May 23, 2025 22:03
Copy link
Contributor

@mikestvz mikestvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test it once is merge and confirm the permission is not affecting anything.

@mikestvz mikestvz added this pull request to the merge queue May 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 24, 2025
@mikestvz mikestvz added this pull request to the merge queue May 24, 2025
Merged via the queue into main with commit 0c02025 May 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants