chore: remove node-bundle in favor of node-backpack #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cdklabs/node-backpack#1167, we moved the code of this private tool to the external `node-backpack` package. Remove it here and use the external tool wherever we used to use the private package.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 79.02% 79.01% -0.02%
==========================================
Files 46 46
Lines 7085 7085
Branches 794 791 -3
==========================================
- Hits 5599 5598 -1
- Misses 1465 1468 +3
+ Partials 21 19 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Total lines changed 2498 is greater than 1000. Please consider breaking this PR down. |
mrgrain
approved these changes
Jun 23, 2025
iliapolo
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cdklabs/node-backpack#1167, we moved the code of this private tool to the external
node-backpackpackage.Remove it here and use the external tool wherever we used to use the private package.
Closes #17
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license