fix: longer timeout for notices in the testing environment #656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 79.01% 79.01%
=======================================
Files 46 46
Lines 7085 7085
Branches 791 791
=======================================
Hits 5598 5598
Misses 1468 1468
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // integration test environment, so wait for a longer timeout there. | ||
| // | ||
| // In production, have a short timeout to not hold up the user experience. | ||
| const timeout = process.env.TESTING ? 30_000 : 3_000; |
There was a problem hiding this comment.
Should we have a more unique env name here? This name feels generic enough for customers to have it set in their enviornment.
There was a problem hiding this comment.
I was debating that. I was actually looking for something like CI, an officiously standardized environment variable, but couldn't find one.
Obviously I can turn it into CDK_TESTING if you'd prefer.
I want to make sure it gets released, that's why it's a fix. |
We're observing a lot of these errors in our integration tests: ``` [09:29:38] Could not refresh notices: _ToolkitError: Network error: Request timed out ``` It could be that our timeout is too short on a heavily congested machine. Increase the timeout specifically for those cases to improve the reliability of our tests.
rix0rrr
force-pushed
the
huijbers/inc-timeout
branch
from
e11cc0e to
72b2dc9
Compare
We're observing a lot of these errors in our integration tests:
It could be that our timeout is too short on a heavily congested machine. Increase the timeout specifically for those cases to improve the reliability of our tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license