fix(s3-deployment): wrong URL in BucketDeployment.deployedBucket.bucketWebsiteUrl #24055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
bug
mrgrain
removed
bug
mrgrain
force-pushed
the
mrgrain/fix/deployed-bucket-wrong-url
branch
from
3befa4f to
a9ceaa0
Compare
aws-cdk-automation
previously requested changes
Feb 7, 2023
mrgrain
force-pushed
the
mrgrain/fix/deployed-bucket-wrong-url
branch
2 times, most recently
from
edb79da to
9653f46
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
…etWebsiteUrl Fixes aws#23354
mrgrain
force-pushed
the
mrgrain/fix/deployed-bucket-wrong-url
branch
from
9653f46 to
38c6742
Compare
github-actions
bot
added
bug
mrgrain
added
effort/medium
rix0rrr
approved these changes
Feb 8, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23354
Without pass-through of all attribute values, it is currently not possible to automatically force a dependency on the deployment for every attribute.
This change merely sets the bucket's region & account, so that all computed website/domain attributes will now include the correct values. Other attributes, and manually set website/domain attributes are not supported.
Additionally the documentation has been extended to highlight the above issue and provide a workaround.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license