feat(efs): throw ValidationErrors instead of untyped Errors

[tttol]

Issue # (if applicable)

Relates to #32569

Reason for this change

Untyped Errors are not recommended.

Description of changes

Change Error to ValidationError.

Describe any new or updated permissions being added

None

Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[tttol]

Exemption Request: This PR did only refactoring.

[aws-cdk-automation]

(This review is outdated)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (2dc5d70) to head (b06a56e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33885   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6938     6938           
  Branches     1170     1170           
=======================================
  Hits         5716     5716           
  Misses       1119     1119           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.38% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tttol]

@kaizencc
I pushed the PR that removes untyped errors.

[badmintoncryer]

@tttol

Thank you for your contribution. Could you please also update .eslintrc.js?

ref: https://github.com/aws/aws-cdk/pull/33870/files

[mrgrain]

@tttol Can you add aws-efs into the list here packages/aws-cdk-lib/.eslintrc.js please? Otherwise looks good!

Edit: Haha, @badmintoncryer you beat me to it :D

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Pull request has been modified.

[tttol]

@badmintoncryer @mrgrain
Thank you for reviewing. I did it! -> b06a56e

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: b06a56e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[kaizencc]

approved! but may have a merge conflict that i have to fix later

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.