Fix CompletableFuture hangs when RetryStrategy/MetricsCollector raise errors #6125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joviegas
reviewed
May 22, 2025
| @@ -57,6 +57,9 @@ public CompletableFuture<OutputT> execute(SdkHttpFullRequest input, RequestExecu | |||
| } else { | |||
| future.complete(r); | |||
| } | |||
| }).exceptionally(t -> { | |||
There was a problem hiding this comment.
whenComplete already handles t != null exception , why do we need exceptionally here?
There was a problem hiding this comment.
This is to handle an exception raised in the whenComplete (ie by the metrics collector)- this is called on the new future returned from whenComplete and not on the original future.
joviegas
approved these changes
May 23, 2025
alextwoods
deleted the
feature/master/alexwoo/handle-retrypolicy-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6008 - Improve error handling in futures in the async pipeline.
Motivation and Context
Errors raised by the RetryStrategy or MetricsCollector in the async request pipeline previously caused the returned future to hang indefinitely because they were never setting a completion state on the returned future. See #6008.
Modifications
Testing
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License