fix(codegen): add default aws regional endpoints for generated clients #7151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/default-aws-endpoints
branch
from
f68cf32 to
f2977f3
Compare
kuhe
force-pushed
the
fix/default-aws-endpoints
branch
from
f2977f3 to
4f78d85
Compare
trivikr
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up with
smithy-lang/smithy-typescript#1589 adds default endpoint ruleset
#7077
The smithy-ts default endpoint ruleset is equivalent to the "customEndpoint" deprecated plugin where an endpoint is required during client instantiation.
This PR overrides the default endpoint ruleset when the model is for an AWS service. It uses an alternate default endpoint ruleset patterned after regional AWS services. In this ruleset, endpoint input for the client is not required, since the endpoint may be derived from the region and service endpoint prefix.
This supports Amazon/AWS model builds that occur outside of our SDK release platform, which normally applies the default endpoint rulesets. This default does not cover as many edge cases as the internal version, but works for typical regional services. Services with further endpoint customizations building outside of our release platform will need to include the endpointRuleSet trait in the model being built.