Skip to content

chore: add Prettier and csharpier action + formatting instructions, format files #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ThirdEyeSqueegee
Copy link
Member

Issue #, if available:
N/A

Description of changes:

  • Add Prettier action
  • Add csharpier action
  • Remove push trigger for build workflow
  • Add pull request types trigger for build workflow
  • Add formatting instructions to CONTRIBUTING.md
  • Format files using csharpier and Prettier
  • Allowlist rutajdash/prettier-cli-action@*

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ThirdEyeSqueegee ThirdEyeSqueegee requested a review from a team as a code owner May 2, 2025 19:25
<ItemGroup>
<ProjectReference Include="..\..\src\Amazon.SecretsManager.Extensions.Caching\Amazon.SecretsManager.Extensions.Caching.csproj"/>
</ItemGroup>
<PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to keep the indent size to 4 to reduce the diff size?

Copy link
Member Author

@ThirdEyeSqueegee ThirdEyeSqueegee May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a unified tab width setting but changing that would affect the tab width for .md, .yml etc. so it might be best to keep it at the default value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants