fix(pacmak): Twine 5.1.0 not found #4554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1.0 in …" This reverts commit 9c7f72e.
rix0rrr
approved these changes
Jun 26, 2024
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
mergify
bot
deleted the
revert-4516-dependabot/pip/packages/jsii-pacmak/lib/targets/python/twine-approx-eq-5.1.0
branch
mergify bot
pushed a commit
to cdklabs/jsii-docgen
that referenced
this pull request
Aug 26, 2024
The Windows compat build has been silently failing for a while due to [the twine issue](aws/jsii#4554) in jsii-pacmak. Fixing the build, by upgrading the pacmak version. Fixing the silent failure by adding a meta job that we can add a branch protection for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twine 5.1.0 has been yanked (removed) due to the issue described in pypa/twine#1125
This PR reverts the
requirements-dev.txtfile used byjsii-pacmakback totwine~=5.0.0.