Skip to content

fix(dotnet-windows): specify versions for dotnet packages to prevent errors in Windows #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

iankhou
Copy link
Contributor

@iankhou iankhou commented Feb 27, 2025

Fixes errors preventing Windows environment test from succeeding.

@jsii/dotnet-runtime:   Failed to restore D:\a\jsii\jsii\packages\@jsii\dotnet-runtime\src\Amazon.JSII.Analyzers.UnitTests\Amazon.JSII.Analyzers.UnitTests.csproj (in 41.02 sec).
@jsii/dotnet-runtime:   Failed to restore D:\a\jsii\jsii\packages\@jsii\dotnet-runtime\src\Amazon.JSII.Runtime.UnitTests\Amazon.JSII.Runtime.UnitTests.csproj (in 41.02 sec).
@jsii/dotnet-runtime-test:   Failed to restore D:\a\jsii\jsii\packages\@jsii\dotnet-runtime-test\test\Amazon.JSII.Runtime.IntegrationTests\Amazon.JSII.Runtime.IntegrationTests.csproj (in 18.44 sec).

Several instances of NU1604 Warning as Error:

@jsii/dotnet-runtime-test: D:\a\jsii\jsii\packages\@jsii\dotnet-runtime-test\test\Amazon.JSII.Runtime.IntegrationTests\Amazon.JSII.Runtime.IntegrationTests.csproj : error NU1604: Warning As Error: Project dependency Microsoft.Extensions.Logging does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iankhou iankhou changed the title specify versions for dotnet packages to prevent errors in Windows fix(dotnet): specify versions for dotnet packages to prevent errors in Windows Feb 27, 2025
@iankhou iankhou changed the title fix(dotnet): specify versions for dotnet packages to prevent errors in Windows fix(dotnet-Windows): specify versions for dotnet packages to prevent errors in Windows Feb 27, 2025
@iankhou iankhou changed the title fix(dotnet-Windows): specify versions for dotnet packages to prevent errors in Windows fix(dotnet-windows): specify versions for dotnet packages to prevent errors in Windows Feb 27, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 27, 2025
@iankhou iankhou self-assigned this Feb 27, 2025
@iankhou iankhou requested a review from mrgrain February 28, 2025 15:27
Copy link
Contributor

mergify bot commented Feb 28, 2025

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Feb 28, 2025
Copy link
Contributor

mergify bot commented Feb 28, 2025

Merging (with squash)...

@mergify mergify bot merged commit 20d1679 into main Feb 28, 2025
30 checks passed
@mergify mergify bot deleted the iankhou-dotnet-fix branch February 28, 2025 15:31
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants