fix(java-runtime): ErrorStreamSink no longer fails with a NullPointerException
#4802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Just realised I neglected to do conventional commits on the actual commits - please let me know if this is an issue, and I'll update and re-raise. |
…nd doesn't have a no argument form
|
Fixed compile error, I think (it's hard to test locally) |
|
Superseded by #4803 |
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
…on` (#4803) All credit for the detection and fix goes to @TimothyJones and his [PR](#4802). This just adds a unit test on top of it. Thanks @TimothyJones ! Fixes #4801 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #4801
I'm unable to run the full test suite locally due to unrelated python and dotnet errors (I suspect I don't have the right versions of something it needs), and unfortunately it doesn't get up to the java-runtime tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.