Skip to content

fix: addWaiterTimeoutHandling #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/sagemaker/predictor_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ def _check_output_and_failure_paths(self, output_path, failure_path, waiter_conf

output_file_found = threading.Event()
failure_file_found = threading.Event()
waiter_error_catched = threading.Event()

def check_output_file():
try:
Expand All @@ -282,7 +283,7 @@ def check_output_file():
)
output_file_found.set()
except WaiterError:
pass
waiter_error_catched.set()

def check_failure_file():
try:
Expand All @@ -294,33 +295,35 @@ def check_failure_file():
)
failure_file_found.set()
except WaiterError:
pass
waiter_error_catched.set()

output_thread = threading.Thread(target=check_output_file)
failure_thread = threading.Thread(target=check_failure_file)

output_thread.start()
failure_thread.start()

while not output_file_found.is_set() and not failure_file_found.is_set():
while (
not output_file_found.is_set()
and not failure_file_found.is_set()
and not waiter_error_catched.is_set()
):
time.sleep(1)

if output_file_found.is_set():
s3_object = self.s3_client.get_object(Bucket=output_bucket, Key=output_key)
result = self.predictor._handle_response(response=s3_object)
return result

failure_object = self.s3_client.get_object(Bucket=failure_bucket, Key=failure_key)
failure_response = self.predictor._handle_response(response=failure_object)
if failure_file_found.is_set():
failure_object = self.s3_client.get_object(Bucket=failure_bucket, Key=failure_key)
failure_response = self.predictor._handle_response(response=failure_object)
raise AsyncInferenceModelError(message=failure_response)

raise (
AsyncInferenceModelError(message=failure_response)
if failure_file_found.is_set()
else PollingTimeoutError(
message="Inference could still be running",
output_path=output_path,
seconds=waiter_config.delay * waiter_config.max_attempts,
)
raise PollingTimeoutError(
message="Inference could still be running",
output_path=output_path,
seconds=waiter_config.delay * waiter_config.max_attempts,
)

def update_endpoint(
Expand Down