feat: add --watch to build command
#29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new --watch flag to the build command that polls the API until the build reaches a final state and prints logs if an error occurs.
- Added a --watch option in BuildArgs to enable watching build progress
- Introduced helper functions (make_api_request, get_program_status, fetch_logs, watch_build_status, and fetch_and_print_logs) to support the watch functionality
- Updated Cargo.toml to include the chrono dependency for timestamp formatting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/commands/build.rs | Added CLI flag --watch and related functionality for polling |
| Cargo.toml | Added chrono dependency for date/time formatting |
| fn check_build_status(program_id: String) -> Result<()> { | ||
| println!("Checking build status for program ID: {}", program_id); | ||
|
|
||
| let status = get_program_status(&program_id)?; |
There was a problem hiding this comment.
Consider extracting and printing only the specific build status field (e.g. status["status"]) instead of the full JSON object to ensure consistency with the output in watch_build_status.
Suggested change
| let status = get_program_status(&program_id)?; | |
| let status_json = get_program_status(&program_id)?; | |
| let status = status_json | |
| .get("status") | |
| .and_then(|s| s.as_str()) | |
| .unwrap_or("unknown"); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watches by polling the api until a final status.
Prints out logs if ends in error.
Written with Zed Agent
Example stdout: