-
-
Notifications
You must be signed in to change notification settings - Fork 228
Update build.gradle - simplify, remove coping and pointing directly to assets folders #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is not correct unless you have a way to exclude files. For instance, the existing implementation handles this in the copy command:
|
Could you explain to me why do we need any exclude rule if there is no *.gz files in Content folder? |
It's not about the |
I see your point but ... I would challenge that. If there is needed for different assets for different platform configuration I would say that having separate folder(s) is the simplest way to go (assestsAndroid/asssestWin etc). I there is need for more sophisticated setup then maybe even exclude could be not enough. Feel free to close this PR if you do not like this simplification |
I understand, and I do agree with that, but from my perspective, it's more about existing projects using Axmol that may utilize the exclude functionality. Providing an alternate solution while also cleaning up the existing implementation would be the way forward.
This is a reasonable solution, so mentioning it in this PR would help any developers that need this functionality.
It's not about liking or disliking changes, but about considering the impact that they may have. It always helps to add some details to the PR as to why the change is happening, and possible alternatives for changes in the functionality. If someone were to look up this PR to see why the changes were made, at least then they would understand the reasoning behind it. |
fair points. Updated title and description |
Hmm it looks like that we really do have *.gz files in assests
I am will close this PR |
Describe your changes
simplify gradle script and removing copy assests functionality
If there is needed for different assets for different platform configuration having separate folder(s) is one of the options to achieve that (assestsAndroid/asssestWin etc)
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR