[WASM] Add javascript click listener to cancel the 'touches' on non touchable devices #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l the current 'touches'
halx99
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in WASM, we can run on devices with touch capabilities (like mobile) or not (desktop with mouse).
In the first case, if the touch is going out of screen it is cancelled, or released if finger doesn't touch the device screen anymore.
In the second case, we know the mouse is clicked, moved but if we move outside the app window and release the mouse no event is triggered, which means the move is in a bad state , still not ended for the GLView.
The only way I found to fix this is to add a javascript click listener only for non touch devices, that triggers an Module call to be used by the GLView to cancel the 'touch' event, if one was existing.