[SW-1712] Pin ubuntu version in workflows #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baxelrod-bdai
requested review from
petercorke,
jhavl and
myeatman-bdai
as code owners
baxelrod-bdai
requested review from
jcao-bdai
and removed request for
petercorke and
jhavl
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Makes sense. Note that there are a lot of references to old Python versions for codecov (3.8) and sphinx (3.7). These are all EOL, and the sphinx action can't resolve dependencies for py3.7 which killed your last build. Suggest bump them all up to 3.12 so we don't have to revisit for a few more years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This is simply a find/replace of
ubuntu-latest->ubuntu-22.04. Becauseubuntu-latestwill become 24.04 soon. We should pin to 22.04 which matches our development environment.Testing Done
None. This PR is the test. (Assuming this repo has CI)