Skip to content

Correct handling of sysconfig._BASE_PREFIX in cross environments. #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

freakboy3742
Copy link
Member

Ensure that sysconfig._BASE_PREFIX is bound to base_prefix, not prefix.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 merged commit 119de47 into main Jun 6, 2025
10 checks passed
@freakboy3742 freakboy3742 deleted the prefix-correction branch June 6, 2025 01:49
freakboy3742 added a commit that referenced this pull request Jun 6, 2025
Ensure that sysconfig._BASE_PREFIX is bound to base_prefix, not prefix.
@mhsmith
Copy link
Member

mhsmith commented Jun 6, 2025

FYI: when getting pybind11 working on Android, I encountered the same issue which led you to override sysconfig._BASE_PREFIX on iOS: that it's used to generate the value of sysconfig.get_path("include").

However, I'm going to try only overriding sysconfig._BASE_[EXEC_]PREFIX and not sys.base_[exec_]prefix, because the latter might have other undesired effects, redirecting things to the target Python which really should be for the build Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants