Add support for visionOS #50

johnzhou721 · 2025-04-12T23:26:07Z

Fixes #49.

I couldn't figure out what the minimum version arg for visionOS is, so I omitted it from the FFI patch I created.

Also, it looks like xxx-CFLAGS is useless in the Makefile so I removed these as well.

PR Checklist:

[X ] All new features have been tested
All new features have been documented
[X ] I have read the CONTRIBUTING.md file
[X ] I will abide by the code of conduct

Signed-off-by: Xinyuan Zhou <[email protected]>

johnzhou721 · 2025-04-12T23:31:07Z

Note my email in the signed-off-by is same as github but differenet from the ``commit author'' -- I use BOTH email addresses.

I forgot what the sign-off-by is called, recall seeing it in the contributor's guide before but can't find it now. Am I still required to do it?

freakboy3742

Thanks for the PR! This looks pretty good as a first pass; there's a couple of things that need to be cleaned up before we can merge it.

The first is the minimum version issue. I suspect you're completely correct that the minimum isn't actually required; however, it's an area where it's worth being explicit, if only so if/when we do need to add a version minimum later, we're not hunting for where that version minimum is required. Given the rapid development of the platform, I think it's not unreasonable to set 2.0 as the minimum; but if you think it's worth including v1.0 devices as well, then I wouldn't object to that either.

The other issue that needs resolution is CI.

Firstly, it looks like your mpdecimal patch has inadvertently broken watchOS support by changing the capitalisation on L16 of the patch.

Secondly, there's also a need to add visionOS to the CI matrix, so that we get visionOS binaries built as part of CI and release processes.

As for the question about commit signing - what you've got here is fine. Having the commit signed is a nice-to-have, but we don't rigorously enforce that requirement.

Makefile

freakboy3742 · 2025-04-13T01:30:45Z

patch/libffi.patch

+    target = 'arm64-apple-xros-simulator'
+    directory = 'darwin_xros'
+    sdk = 'xrsimulator'
+    version_min = ''


For consistency, my inlination here would be to enforce visionOS 2.0 as well.

johnzhou721 · 2025-04-13T02:33:14Z

Thanks for reviewing my patch!

watchOS is TextEdit autocorrect...

johnzhou721 · 2025-04-13T02:51:18Z

OK Python-Apple-Support for xrOS is also coming together for the first time in forever...

Actual device already compiled, waiting for simulator to do it

After that I'll start a PR on that repo as well.

Will fix those things tomorrow, except the version issue which I don't know the flag for.

johnzhou721 · 2025-04-13T03:31:08Z

I just added 3 commits for these stuff. Hope it looks great! Will test on my own box tomorrow

johnzhou721 · 2025-04-13T03:31:26Z

@freakboy3742 Can you approve CI? Thanks!

freakboy3742

Looks good - and looks like it's passing CI.

The one last issue is almost entirely cosmetic, but it's one of those cosmetic details with a big UI impact - the naming of the platform.

Apple uses iphoneos and iphonesimulator to refer to platform that everyone calls
"iOS". They use appletvos and appletvsimulator to refer to "tvOS".

By extension, while xros and xrsimulator are the names used internally by Apple's tooling, "visionOS" is the name everyone actually knows. On that basis - I'd suggest that the public names (i.e., the Makefile and CI targets) should use the visionOS name, rather than xros or xrOS.

Apologies for not picking this earlier - it only stood out when the CI reported success on the xrOS build. The change should be mostly search and replace though.

johnzhou721 · 2025-04-13T04:14:01Z

Great! Also Python-Apple-Support -- I have a newer pkg-config m4 file so the patch over there is failing again. Before I figure out this issue with the m4 macro version on my own computer, could you please run autoreconf on your platform on your cpython?

Also xros is also the name of a vape so I guess... not good. Will commit

freakboy3742 · 2025-04-13T04:16:08Z

Great! Also Python-Apple-Support -- I have a newer pkg-config m4 file so the patch over there is failing again. Before I figure out this issue with the m4 macro version on my own computer, could you please run autoreconf on your platform on your cpython?

Will do - but as a heads up, it's a lot easier to keep comments about repos constrained to the repos they affect. I get notified on every change on every BeeWare repo; if you drop a comment on Python-Apple-support, I'll see it there.

johnzhou721 · 2025-04-13T04:16:31Z

nvm -- will do tomorrow it's getting later

johnzhou721 · 2025-04-13T15:19:38Z

Done!

johnzhou721 · 2025-04-13T15:26:37Z

Since we're dealing with XZ Utils here: Beware (or should I say BeeWare) of ALL of my patches, because I might be Jia Tan, only that I'm probably more sus than Jia Tan with a 1-day account,

johnzhou721 · 2025-04-13T17:14:51Z

Actually I changed everything except for the SDKs to use visionOS, looks like Apple's tooling handles visoinOS as well,

freakboy3742

A few more comments inline, mostly related to xros/visionOS consistency.

Unfortunately, because you've created this PR from a main branch, I can't push any changes; so I've opened #52 that represents the changes from this PR, plus the changes from this review, plus one last change to account for the consistent use of xros in target triples.

freakboy3742 · 2025-04-13T22:21:43Z

Makefile

 # - XZ              - build XZ for all platforms
 # - XZ-iOS          - build XZ for iOS
 # - XZ-tvOS         - build XZ for tvOS
 # - XZ-watchOS      - build XZ for watchOS
+# - XZ-xrOS         - build XZ for xrOS


Suggested change

# - XZ-xrOS - build XZ for xrOS

# - XZ-visionOS - build XZ for visionOS

More generally, there's an indentation issue across these comments - the - build... comments should all be aligned.

freakboy3742 · 2025-04-13T22:23:18Z

patch/libffi.patch

+ 	     | sym* |  plan9* | psp* | sim* | xray* | os68k* | v88r* \
+ 	     | hiux* | abug | nacl* | netware* | windows* \
+-	     | os9* | macos* | osx* | ios* | tvos* | watchos* \
+	     | os9* | macos* | osx* | ios* | tvos* | watchos* | xros* | visionos* \


freakboy3742 · 2025-04-13T22:23:39Z

patch/libffi.patch

+ 	os2-emx-)
+ 		;;
+-	ios*-simulator* | tvos*-simulator* | watchos*-simulator*)
+	ios*-simulator* | tvos*-simulator* | watchos*-simulator* | xros*-simulator* | visionos*-simulator*)


freakboy3742 · 2025-04-13T22:26:32Z

patch/mpdecimal.patch

+@@ -1713,3 +1713,3 @@
+ 	     | hiux* | abug | nacl* | netware* | windows* \
+-	     | os9* | macos* | osx* | ios* | tvos* | watchos* \
+	     | os9* | macos* | osx* | ios* | tvos* | watchos* | xros* | visionos* \


freakboy3742 · 2025-04-13T22:26:52Z

patch/mpdecimal.patch

 @@ -1792,6 +1792,8 @@
 	os2-emx)
 		;;
 	*-eabi* | *-gnueabi*)
 +		;;
-+	ios*-simulator | tvos*-simulator | watchos*-simulator)
+	ios*-simulator | tvos*-simulator | watchos*-simulator | xros*-simulator | visionos*-simulator)


freakboy3742 · 2025-04-13T23:52:56Z

Makefile

+TARGETS-visionOS=xrsimulator.arm64 xros.arm64
+VERSION_MIN-visionOS=2.0
+# Apple made lives harder by NOT having a -version-min flag
+PYTHON_CONFIGURE-xrOS=ac_cv_func_sigaltstack=no


This variable won't be used as-defined... which does raise the question of whether it is needed at all.

Suggested change

PYTHON_CONFIGURE-xrOS=ac_cv_func_sigaltstack=no

PYTHON_CONFIGURE-visionOS=ac_cv_func_sigaltstack=no

freakboy3742 · 2025-04-13T23:53:29Z

patch/libffi.patch

+     version_min = '-mwatchos-version-min=4.0'
+    
+class visionos_simulator_arm64_platform(arm64_platform):
+    target = 'arm64-apple-visionos-simulator'


Suggested change

+ target = 'arm64-apple-visionos-simulator'

+ target = 'arm64-apple-xros2.0-simulator'

freakboy3742 · 2025-04-13T23:55:32Z

patch/libffi.patch

+
+
+class visionos_device_arm64_platform(arm64_platform):
+    target = 'arm64-apple-visionos'


Suggested change

+ target = 'arm64-apple-visionos'

+ target = 'arm64-apple-xros2.0'

I'd also leave a comment against version_min (in both configs) indicating that the minimum version is defined by the target triple.

freakboy3742 · 2025-04-14T00:00:09Z

Makefile

+# visionOS targets
+TARGETS-visionOS=xrsimulator.arm64 xros.arm64
+VERSION_MIN-visionOS=2.0
+# Apple made lives harder by NOT having a -version-min flag


Suggested change

# Apple made lives harder by NOT having a -version-min flag

# visionOS doesn't expose -mxros-version-min or similar; it uses the version

# number in the -target triple, or a definition like:

# CFLAGS-visionOS=-arch arm64 -mtargetos=xros$(VERSION_MIN-visionOS)

# For consistency with existing tooling, we use the -target form.

freakboy3742 · 2025-04-14T00:40:18Z

Closing in favor of #52, due to this PR being from a main branch.

Add support for visionOS

50f3205

Signed-off-by: Xinyuan Zhou <[email protected]>

johnzhou721 force-pushed the main branch from fb19036 to 50f3205 Compare April 12, 2025 23:30

freakboy3742 requested changes Apr 13, 2025

View reviewed changes

freakboy3742 mentioned this pull request Apr 13, 2025

Add support for maccatalyst #43

Closed

4 tasks

johnzhou721 added 3 commits April 12, 2025 22:28

ok great 2.0 right?

cac80e3

I hate TextEdi

c2d3c79

add ci

42b1743

freakboy3742 requested changes Apr 13, 2025

View reviewed changes

johnzhou721 added 2 commits April 13, 2025 10:18

Apple, could you please use one name for each product?

ac6e409

update workflows

21cba8e

johnzhou721 requested a review from freakboy3742 April 13, 2025 17:13

freakboy3742 mentioned this pull request Apr 14, 2025

Add support for visionOS #52

Merged

4 tasks

freakboy3742 reviewed Apr 14, 2025

View reviewed changes

freakboy3742 closed this Apr 14, 2025

johnzhou721 mentioned this pull request Apr 14, 2025

Document visionOS Support #53

Merged

4 tasks

	# - XZ-xrOS - build XZ for xrOS
	# - XZ-visionOS - build XZ for visionOS

	+ \| os9* \| macos* \| osx* \| ios* \| tvos* \| watchos* \| xros* \| visionos* \
	+ \| os9* \| macos* \| osx* \| ios* \| tvos* \| watchos* \| xros* \

	+ ios-simulator \| tvos-simulator \| watchos-simulator \| xros-simulator \| visionos-simulator)
	+ ios-simulator \| tvos-simulator \| watchos-simulator \| xros-simulator)

	+ ios-simulator \| tvos-simulator \| watchos-simulator \| xros-simulator \| visionos*-simulator)
	+ ios-simulator \| tvos-simulator \| watchos-simulator \| xros-simulator)

	PYTHON_CONFIGURE-xrOS=ac_cv_func_sigaltstack=no
	PYTHON_CONFIGURE-visionOS=ac_cv_func_sigaltstack=no

	+ target = 'arm64-apple-visionos-simulator'
	+ target = 'arm64-apple-xros2.0-simulator'



		+class visionos_device_arm64_platform(arm64_platform):
		+ target = 'arm64-apple-visionos'

	+ target = 'arm64-apple-visionos'
	+ target = 'arm64-apple-xros2.0'

-# Apple made lives harder by NOT having a -version-min flag
+# visionOS doesn't expose -mxros-version-min or similar; it uses the version
+# number in the -target triple, or a definition like:
+# CFLAGS-visionOS=-arch arm64 -mtargetos=xros$(VERSION_MIN-visionOS)
+# For consistency with existing tooling, we use the -target form.

Uh oh!

Add support for visionOS #50

Add support for visionOS #50

Uh oh!

Conversation

johnzhou721 commented Apr 12, 2025

PR Checklist:

Uh oh!

johnzhou721 commented Apr 12, 2025

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

freakboy3742 commented Apr 13, 2025

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

johnzhou721 commented Apr 13, 2025

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

freakboy3742 commented Apr 14, 2025

Uh oh!

Uh oh!