-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Update to rodio
0.18
#13612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rodio
0.18
#13612
Conversation
--- updated-dependencies: - dependency-name: rodio dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple change, assuming the examples still work (can't check right now), this looks fine!
Release notes: https://github.com/RustAudio/rodio/blob/master/CHANGELOG.md#version-0180-2024-05-05 Nothing stands out to me as particularly worrying or vital. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also assuming the examples still work, and having looked at the rodio changelog
I don't know how keen to actually go forward with it I am, but I'll mention that rodio 0.18 includes the change I made to |
If / once this gets merged, I'll create an issue for this and check if the Better Audio working group is interested. They can decide whether it's worth working on, or if all efforts should be put into the |
Objective
rodio
released 0.18! While we are working on migrating away from it and towardskira
, it is still good to keep our dependencies up-to-date.Solution
Cargo.toml
to depend onrodio
0.18.rodio
forwasm32-unknown-unknown
too.Testing
spatial_audio_2d
.Changelog
rodio
to 0.18.