Skip to content

Update to rodio 0.18 #13612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Update to rodio 0.18 #13612

merged 2 commits into from
Jun 2, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented May 31, 2024

Objective

Solution

Testing

  • The CI should catch any errors here, but you can also run an audio example if you want like spatial_audio_2d.

Changelog

  • Updated rodio to 0.18.

@BD103 BD103 added A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 31, 2024
dependabot bot and others added 2 commits May 31, 2024 14:01
---
updated-dependencies:
- dependency-name: rodio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor

@Olle-Lukowski Olle-Lukowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, assuming the examples still work (can't check right now), this looks fine!

@alice-i-cecile
Copy link
Member

alice-i-cecile commented May 31, 2024

Release notes: https://github.com/RustAudio/rodio/blob/master/CHANGELOG.md#version-0180-2024-05-05

Nothing stands out to me as particularly worrying or vital.

Copy link
Contributor

@SolarLiner SolarLiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also assuming the examples still work, and having looked at the rodio changelog

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 31, 2024
@mweatherley
Copy link
Contributor

I don't know how keen to actually go forward with it I am, but I'll mention that rodio 0.18 includes the change I made to SpatialSink, which theoretically allows the current audio system to be restructured to reuse its audio sinks.

@BD103
Copy link
Member Author

BD103 commented Jun 1, 2024

I don't know how keen to actually go forward with it I am, but I'll mention that rodio 0.18 includes the change I made to SpatialSink, which theoretically allows the current audio system to be restructured to reuse its audio sinks.

If / once this gets merged, I'll create an issue for this and check if the Better Audio working group is interested. They can decide whether it's worth working on, or if all efforts should be put into the kira migration instead.

@mockersf mockersf added this pull request to the merge queue Jun 2, 2024
Merged via the queue into bevyengine:main with commit 7d3fcd5 Jun 2, 2024
32 checks passed
@BD103 BD103 deleted the rodio-0.18 branch June 2, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants