Skip to content

Simplified on_replace and on_despawn relationship hooks. #19378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2025
Merged

Simplified on_replace and on_despawn relationship hooks. #19378

merged 3 commits into from
Jun 2, 2025

Conversation

AlephCubed
Copy link
Contributor

Fixes #18364.

@alice-i-cecile alice-i-cecile requested a review from chescock June 2, 2025 19:04
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 2, 2025
@chescock chescock added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 2, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 2, 2025
@alice-i-cecile
Copy link
Member

@AlephCubed I think you need to add back an import :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 2, 2025
Merged via the queue into bevyengine:main with commit 415f6d8 Jun 2, 2025
32 checks passed
@AlephCubed AlephCubed deleted the simplify-relation-hook branch June 2, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@chescock chescock chescock approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify on_replace relations hook
3 participants
@AlephCubed @alice-i-cecile @chescock