fix: Ensure linear volume subtraction does not go below zero #19423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Solution - Clamp the result of linear volume subtraction to a minimum of 0.0 - Add a new test case to verify behavior when subtracting beyond zero
foxzool
changed the title
SolarLiner
suggested changes
May 29, 2025
Comment on lines
192
to
196
| match (self, rhs) { | ||
| (Linear(a), Linear(b)) => Linear(a - b), | ||
| (Linear(a), Linear(b)) => Linear((a - b).max(0.0)), | ||
| (Decibels(a), Decibels(b)) => Decibels(linear_to_decibels( | ||
| decibels_to_linear(a) - decibels_to_linear(b), | ||
| )), |
There was a problem hiding this comment.
The only correct solution here is to simply not impl Add/Sub on Volume. Linear volumes are like percentages, and it does not make sense to add or subtract percentages. It's similar here with "linear volume": if the volume is at 0.5 and you want to reduce it by another 0.5, you should end up with 0.25 instead of 0.
janhohenheim
approved these changes
May 29, 2025
janhohenheim
added
D-Trivial
My recommendation would be for this PR to remove the impls, and mark this a breaking change in case people have accidentally/intentionally relied on this impl existing. |
janhohenheim
added
S-Waiting-on-Author
janhohenheim
suggested changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Ensure linear volume subtraction does not go below zero
Solution