Skip to content

Rename TextLayout #19444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Rename TextLayout #19444

wants to merge 8 commits into from

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented May 30, 2025 •
edited
Loading

Objective

Rename the TextLayout component. it doesn't contain the text layout, just the justification and linebreak settings.

Solution

Renamed TextLayout to TextLayoutSettings.

Renamed some function params typed TextLayoutSettings but named block and layout to layout_settings.

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 30, 2025
@ickshonpe ickshonpe added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ickshonpe