Skip to content

implement prop: and attr: namespace for props #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

brainkim
Copy link
Member

@brainkim brainkim commented Apr 22, 2025

Implements #281

@brainkim brainkim force-pushed the force-prop-or-attr branch from 2e2bb05 to 0f8f6a8 Compare April 22, 2025 00:49
@brainkim brainkim force-pushed the force-prop-or-attr branch from 0f8f6a8 to e5e6e6c Compare April 22, 2025 00:53
@brainkim
Copy link
Member Author

Thought a little bit about whether it’s wise to use an attribute namespace (prop:, attr:). It could potentially cause issues with exotic XML things, but I think it’s better than the alternatives. prop$, attr$ is ugly and not as clear. . and # are invalid characters. prop- and attr- could potentially have similar issues. prop:/attr: is probably fine and only requires that JSX parsers don’t throwIfNamespace. Crank.js already doesn’t have a problem with namespaced attributes so this is a non-issue.

@brainkim brainkim merged commit 9c7991d into main Apr 22, 2025
1 check passed
@brainkim brainkim deleted the force-prop-or-attr branch April 22, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant